# SQSH-3853 handoff

## Goal
Implement web scope for `SQSH-3853`.

Ticket:
- `SQSH-3853` — Web | Groups | Módulo de Grupos en settings de notificaciones
- Parent: `SQSH-3852`
- Design/benchmark ticket: `SQSH-3842`

## Branch/worktree
- Repo: `humand-web`
- Branch: `feat/SQSH-3853-web-groups-modulo-de-grupos-en-settings-de-notificaciones`
- Worktree: `/home/sebas/work/humand/humand-web--SQSH-3853-web-groups-modulo-de-grupos-en-settings-de-notificaciones`

## User decisions locked
- Scope interpretation: **expected**
  - add `Groups` module card in `/notifications-config`
  - entering it should show user's groups
  - clicking a group should open notification configuration for that group
- UX direction: **B**
  - build **new settings-style toggles**
  - do **not** reuse existing group notification drawer as final UX
- User asked to **navigate to the ticket with the figma design too**
  - checked `SQSH-3842`
  - no Jira Figma custom field found
  - found benchmark/design board link in description:
    - `https://www.figma.com/board/4pjWoXVSnuvyK998Z6bvBB/Benchmark--Workplace?node-id=1735-4972&t=wspizRVT0GxX7J9d-4`

## Repo/context findings
### Notifications settings page
- Main page: `src/pages/dashboard/notifications/NotificationsConfig/index.tsx`
- README: `src/pages/dashboard/notifications/README.md`
- Notification constants/modules: `src/pages/dashboard/notifications/constants.ts`
- Notification helpers: `src/pages/dashboard/notifications/utils.ts`

Relevant current behavior:
- notifications settings currently renders cards for modules
- when a module is selected, it usually renders `NotificationChannels`
- `GROUPS` already exists in `NotificationModuleCodes` and `moduleIcons`
- `GROUPS` is already part of `notificationsModulesSet`
- current generic channel config only supports module-level channels; special-case today is `FEED`

### Existing groups notifications behavior
- Existing drawer hook: `src/pages/dashboard/groups/components/useGroupNotificationsSettingsDrawer.tsx`
- Existing group routes: `src/pages/dashboard/groups/routes.ts`
- Group list page: `src/pages/dashboard/groups/index.tsx`
- Group notification-related queries appear under groups module and services

This suggests implementation may need:
- fetch user's groups for notifications settings detail page
- new settings-style list/detail UI for groups notification prefs
- reuse data/services/mutations from existing group notification logic, but not reuse the drawer UX directly

## Technical blockers already hit
### Runtime
- worktree created successfully
- dependency install failed because repo expects Node `24.11.1`
- machine currently has Node `22.22.2`
- `check-runtime.sh` tried auto-fix and failed
- `.nvmrc` in repo is `24.11.1`
- `~/.nvm/nvm.sh` not present on this machine

Impact:
- another agent should avoid claiming validation until runtime is fixed or another working Node 24 toolchain is used

### GitHub auth
- resolved during setup by switching `gh` to work account `sfavaron-hu`

## Jira/requirements summary
### SQSH-3852 parent story highlights
- add `Groups` entry point into notification settings
- show groups user belongs to
- consider name + avatar, ordering, search/filter, long-list handling, empty state
- web + mobile story overall, but this branch is web subtask
- current per-group notification config already exists elsewhere; same underlying preferences must remain source of truth

### SQSH-3842 design notes found in Jira text
- compare A vs B
- user explicitly chose **B** for this implementation
- benchmark/design board link present, but no direct Figma file field resolved from Jira REST

## Open questions for next agent
1. What exact web design source should be treated as canonical beyond the benchmark board?
   - Jira has benchmark board link, but no resolved implementation-ready Figma file URL.
2. What exact list data source should power “groups I belong to” in notifications settings?
   - likely groups list APIs already used in groups pages, but not yet traced fully.
3. For option B, should selecting a group:
   - open an in-page detail view under `/notifications-config?module=groups&groupId=...`, or
   - open a dedicated settings-style drawer/modal/page?
   User only locked **B**, not the exact web interaction container.
4. Which subset of per-group preferences exists today and must be mirrored exactly in the new settings-style UI?
5. Are search/pagination/empty/error states all required in this subtask now, or can web ship MVP list first if backend paging patterns already constrain scope?

## Recommended next steps for another agent
1. Read `useGroupNotificationsSettingsDrawer.tsx` and related group services/types.
2. Trace group list fetch + per-group notification fetch/update endpoints.
3. Inspect benchmark/design board and derive concrete web UI behavior.
4. Write design/plan artifact if following full Humand skill gates.
5. Implement with tests first once behavior is locked.
6. Validate under Node 24.11.1 before claiming done.